Skip to content

New: Add button icon option (fix #217) #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New: Add button icon option (fix #217) #222

wants to merge 2 commits into from

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jun 20, 2025 •
edited
Loading

Fix #217

New

  • Adds the option to have an icon on the link <button>
  • New content object properties for _linkIconClass and _linkIconPosition

Questions

  • I did not update any schemas. If we were to add this to schemas, should it go alongside linkText in the core content object schemas? Or should this be specific to Box Menu? If the latter, we would need to change the config to _boxMenu._linkIconClass and _boxMenu._linkIconPosition.

Screenshots

@swashbuck swashbuck self-assigned this Jun 20, 2025
@swashbuck swashbuck moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jun 20, 2025
@swashbuck swashbuck changed the title New: Add link icon option (fix #217) New: Add button icon option (fix #217) Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the option to include an icon in the menu item button
1 participant
@swashbuck